Don't allow new windows to be created outside the monitor's work area....

chrome/browser/ui/views/tabs/dragged_tab_controller.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tabs/dragged_tab_controller.h"
 
 #include <math.h>
 #include <set>
 
 #include "base/callback.h"
@@ skipping 519 matching lines @@
   window_create_point_.Offset(mouse_offset_.x(), mouse_offset_.y());
 }
 
 gfx::Point DraggedTabController::GetWindowCreatePoint() const {
   gfx::Point cursor_point = GetCursorScreenPoint();
   if (dock_info_.type() != DockInfo::NONE) {
     // If we're going to dock, we need to return the exact coordinate,
     // otherwise we may attempt to maximize on the wrong monitor.
     return cursor_point;
   }
+  // If the cursor is outside the monitor area, move it inside. For example,
+  // dropping a tab onto the task bar on Windows produces this situation.
+  DockInfo dock_info_for_cursor = DockInfo::GetDockInfoAtPoint(cursor_point,
+    std::set<gfx::NativeView>());

[sky, 2011/01/21 18:55:19]

this should be indented by 4.

Using DockInfo to get the monitor bounds is a bit of a hack. Instead add a
method to views/screen, say GetMonitorWorkArea, that you call and DockInfo
calls.

+  if (cursor_point.x() < dock_info_for_cursor.monitor_bounds().x())
+    cursor_point.set_x(dock_info_for_cursor.monitor_bounds().x());
+  else if (cursor_point.x() > dock_info_for_cursor.monitor_bounds().right())
+    cursor_point.set_x(dock_info_for_cursor.monitor_bounds().right());
+  if (cursor_point.y() < dock_info_for_cursor.monitor_bounds().y())
+    cursor_point.set_y(dock_info_for_cursor.monitor_bounds().y());
+  else if (cursor_point.y() > dock_info_for_cursor.monitor_bounds().bottom())
+    cursor_point.set_y(dock_info_for_cursor.monitor_bounds().bottom());
   return gfx::Point(cursor_point.x() - window_create_point_.x(),
                     cursor_point.y() - window_create_point_.y());
 }
 
 void DraggedTabController::UpdateDockInfo(const gfx::Point& screen_point) {
   // Update the DockInfo for the current mouse coordinates.
   DockInfo dock_info = GetDockInfoAtPoint(screen_point);
   if (source_tabstrip_->type() == BaseTabStrip::VERTICAL_TAB_STRIP &&
       ((dock_info.type() == DockInfo::LEFT_OF_WINDOW &&
         !base::i18n::IsRTL()) ||
@@ skipping 786 matching lines @@
 #else
     NOTIMPLEMENTED();
 #endif
   }
 }
 
 TabStripModel* DraggedTabController::GetModel(BaseTabStrip* tabstrip) const {
   return static_cast<BrowserTabStripController*>(tabstrip->controller())->
       model();
 }