Implement RenderWidgetHostViewViews::Destroy. See RWHVGtk for reference.

chrome/browser/renderer_host/render_widget_host_view_views.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_widget_host_view_views.h"
 
 #include <algorithm>
 #include <string>
 
 #include "app/l10n_util.h"
@@ skipping 112 matching lines @@
       is_loading_(false),
       native_cursor_(NULL),
       is_showing_context_menu_(false),
       visually_deemphasized_(false),
       touch_event_() {
   SetFocusable(true);
   host_->set_view(this);
 }
 
 RenderWidgetHostViewViews::~RenderWidgetHostViewViews() {
-  RenderViewGone(base::TERMINATION_STATUS_NORMAL_TERMINATION,
-                 ResultCodes::NORMAL_EXIT);
+  if (GetRenderWidgetHost())
+    RenderViewGone(base::TERMINATION_STATUS_NORMAL_TERMINATION,

[Greg Spencer (Chromium), 2011/01/19 21:59:38]

Hmm.  I can see what you mean, and in fact this is a bad idea: RenderViewGone is
a virtual function, and we shouldn't be calling it in the destructor.  I didn't
actually add that, however, you added it in:

http://src.chromium.org/viewvc/chrome?view=rev&revision=64015

(I just added some parameters to the call in my patch)

I'm wondering if we should be calling this in "Destroy" instead?  (But I'm not
sure that Destroy is reliably called for every object.)

+                   ResultCodes::NORMAL_EXIT);
 }
 
 void RenderWidgetHostViewViews::InitAsChild() {
   Show();
 }
 
 RenderWidgetHost* RenderWidgetHostViewViews::GetRenderWidgetHost() const {
   return host_;
 }
 
@@ skipping 141 matching lines @@
   }
 }
 
 void RenderWidgetHostViewViews::RenderViewGone(base::TerminationStatus status,
                                                int error_code) {
   GetRenderWidgetHost()->ViewDestroyed();
   Destroy();
 }
 
 void RenderWidgetHostViewViews::Destroy() {
-  // TODO(anicolao): deal with any special popup cleanup
-  NOTIMPLEMENTED();
+  // host_'s destruction brought us here, null it out so we don't use it
+  host_ = NULL;
+
+  if (GetParent())
+    GetParent()->RemoveChildView(this);
+  MessageLoop::current()->DeleteSoon(FROM_HERE, this);
 }
 
 void RenderWidgetHostViewViews::SetTooltipText(const std::wstring& tip) {
   // TODO(anicolao): decide if we want tooltips for touch (none specified
   // right now/might want a press-and-hold display)
   // NOTIMPLEMENTED(); ... too annoying, it triggers for every mousemove
 }
 
 void RenderWidgetHostViewViews::SelectionChanged(const std::string& text) {
   // TODO(anicolao): deal with the clipboard without GTK
@@ skipping 445 matching lines @@
 }
 
 // static
 RenderWidgetHostView*
     RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView(
         gfx::NativeView widget) {
   gpointer user_data = g_object_get_data(G_OBJECT(widget),
                                          kRenderWidgetHostViewKey);
   return reinterpret_cast<RenderWidgetHostView*>(user_data);
 }