Issue 6380001: Disabled GPU process prelaunch field trial....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6380001: Disabled GPU process prelaunch field trial.... (Closed)

Created:
9 years, 11 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disabled GPU process prelaunch field trial. This might be causing the GPU to hang even when not viewing GPU hardware accelerated content. An example appears to be the ATI HD2600 on mac. TEST=try BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71737

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -26 lines)			Patch
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/renderer/render_thread.cc	View	2 chunks	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

9 years, 11 months ago (2011-01-18 22:28:33 UTC) #2

It might be better to leave in the command line option and #ifdef the code, so
it will be easier to enable if we decide to re-enable the field trial later.

LGTM assuming that we're going to fix the root cause by avoiding running
problematic code on this GPU.

Expand Messages | Collapse Messages