Issue 6379007: ARM: Implement DoCmpID and DoCmpIDAndBranch in the lithium code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6379007: ARM: Implement DoCmpID and DoCmpIDAndBranch in the lithium code generator. (Closed)

Created:
9 years, 11 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

ARM: Implement DoCmpID and DoCmpIDAndBranch in the lithium code generator. BUG=none TEST=none

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -3 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+44 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/6379007/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6379007/diff/1/src/arm/lithium-codegen-arm.cc#newcode1672 src/arm/lithium-codegen-arm.cc:1672: // If a NaN is involved, i.e. the ...

9 years, 10 months ago (2011-02-04 10:20:53 UTC) #2

Karl Klose

9 years, 10 months ago (2011-02-04 11:26:51 UTC) #3

On 2011/02/04 10:20:53, Søren Gjesse wrote:
> LGTM
> 
> http://codereview.chromium.org/6379007/diff/1/src/arm/lithium-codegen-arm.cc
> File src/arm/lithium-codegen-arm.cc (right):
> 
>
http://codereview.chromium.org/6379007/diff/1/src/arm/lithium-codegen-arm.cc#...
> src/arm/lithium-codegen-arm.cc:1672: // If a NaN is involved, i.e. the result
is
> unordered (V set),
> jump to unordered -> jump to false label.

Done.

Expand Messages | Collapse Messages