Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 6379006: cros_workon: allow a stop on a dead package (Closed)

Created:
9 years, 11 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
davidjames, anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

cros_workon: allow a stop on a dead package Previously, you could not stop working on a package if its ebuild had been removed. This fixes this issue by skipping canonicalization if the package name exactly matches a name in the workon file. BUG=11214 TEST=See below. (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list sys-kernel/chromeos-kernel (cros-chroot) msb@msb ~/trunk/src/scripts $ echo "=foo/bar-9999" >> ~/trunk/.config/cros_workon/x86-generic (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list sys-kernel/chromeos-kernel foo/bar (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic stop foo/bar !!! No packages matching 'foo/bar' WARNING: error looking up package foo/bar ERROR : Error parsing package list *** I made changes to cros_workon here (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list sys-kernel/chromeos-kernel foo/bar (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic stop foo/bar INFO : Stopped working on 'foo/bar' for 'x86-generic' (cros-chroot) msb@msb ~/trunk/src/scripts $ ./cros_workon --board x86-generic list sys-kernel/chromeos-kernel Change-Id: Id5cbd2b145b4d0fca96cfb245f1ac99e0b3cbdf3 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=07f9209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M cros_workon View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
9 years, 11 months ago (2011-01-24 21:54:43 UTC) #1
davidjames
9 years, 11 months ago (2011-01-24 21:56:54 UTC) #2
LGTM, please file a bug :)

Powered by Google App Engine
This is Rietveld 408576698