Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Issue 6378012: Disable all code motion on the final optimization attempt. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Disable all code motion on the final optimization attempt. Before, we disabled code motion for check instructions on the final optimization attempt. It is unsafe to prevent movement of check instructions but to allow movement of instructions that assume the checks were performed. Committed: http://code.google.com/p/v8/source/detail?r=6485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 2 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 11 months ago (2011-01-26 10:02:25 UTC) #1
fschneider
9 years, 11 months ago (2011-01-26 10:24:35 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698