Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4892)

Unified Diff: chrome/common/extensions/extension_sidebar_utils.h

Issue 6378009: Only allow extension pages to be displayed in the sidebar to be consistent... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_sidebar_utils.h
===================================================================
--- chrome/common/extensions/extension_sidebar_utils.h (revision 72219)
+++ chrome/common/extensions/extension_sidebar_utils.h (working copy)
@@ -16,11 +16,10 @@
// Returns id of an extension owning a sidebar identified by |content_id|.
std::string GetExtensionIdByContentId(const std::string& content_id);
-// Resolves |url_string| relative to |extension|'s url and verifies it
-// against |extension|'s host permissions.
+// Resolves |relative_path| relative to |extension|'s url.
// In case of any problem, returns an empty invalid GURL and |error| receives
// the corresponding error message.
-GURL ResolveAndVerifyUrl(const std::string& url_string,
+GURL ResolveRelativePath(const std::string& relative_path,
const Extension* extension,
std::string* error);
« no previous file with comments | « chrome/common/extensions/extension_sidebar_defaults.h ('k') | chrome/common/extensions/extension_sidebar_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698