Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/common/extensions/extension_sidebar_defaults.h

Issue 6378009: Only allow extension pages to be displayed in the sidebar to be consistent... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_sidebar_defaults.h
===================================================================
--- chrome/common/extensions/extension_sidebar_defaults.h (revision 72219)
+++ chrome/common/extensions/extension_sidebar_defaults.h (working copy)
@@ -11,8 +11,6 @@
#include "base/string16.h"
#include "googleurl/src/gurl.h"
-class SkBitmap;
-
// ExtensionSidebarDefaults encapsulates the default parameters of a sidebar,
// as defined in the extension manifest.
class ExtensionSidebarDefaults {
@@ -31,18 +29,19 @@
return default_icon_path_;
}
- // Default sidebar url, resolved and verified against extension permissions.
- void set_default_url(const GURL& url) {
- default_url_ = url;
+ // A resolved |url| to extension resource (manifest default_page key value)
+ // to navigate sidebar to by default.
+ void set_default_page(const GURL& url) {
+ default_page_ = url;
}
- const GURL& default_url() const {
- return default_url_;
+ const GURL& default_page() const {
+ return default_page_;
}
private:
string16 default_title_;
std::string default_icon_path_;
- GURL default_url_;
+ GURL default_page_;
};
#endif // CHROME_COMMON_EXTENSIONS_EXTENSION_SIDEBAR_DEFAULTS_H_
« no previous file with comments | « chrome/common/extensions/extension_manifests_unittest.cc ('k') | chrome/common/extensions/extension_sidebar_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698