chrome/common/extensions/extension_constants.cc - Issue 6378009: Only allow extension pages to be displayed in the sidebar to be consistent...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_constants.cc

Issue 6378009: Only allow extension pages to be displayed in the sidebar to be consistent... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension.cc ('K') | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_manifests_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_constants.cc

===================================================================

--- chrome/common/extensions/extension_constants.cc (revision 72219)

+++ chrome/common/extensions/extension_constants.cc (working copy)

@@ -54,8 +54,8 @@

const char* kRunAt = "run_at";

const char* kSidebar = "sidebar";

const char* kSidebarDefaultIcon = "default_icon";

+const char* kSidebarDefaultPage = "default_page";

const char* kSidebarDefaultTitle = "default_title";

-const char* kSidebarDefaultUrl = "default_url";

const char* kSignature = "signature";

const char* kTheme = "theme";

const char* kThemeColors = "colors";

@@ -233,10 +233,10 @@

"Invalid value for 'sidebar'.";

const char* kInvalidSidebarDefaultIconPath =

"Invalid value for 'sidebar.default_icon'.";

+const char* kInvalidSidebarDefaultPage =

+ "Invalid value for 'sidebar.default_page'.";

const char* kInvalidSidebarDefaultTitle =

"Invalid value for 'sidebar.default_title'.";

-const char* kInvalidSidebarDefaultUrl =

- "Invalid value for 'sidebar.default_url'.";

const char* kInvalidSignature =

"Value 'signature' is missing or invalid.";

const char* kInvalidTheme =