Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: chrome/browser/sidebar/sidebar_container.h

Issue 6378009: Only allow extension pages to be displayed in the sidebar to be consistent... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_ 5 #ifndef CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_
6 #define CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_ 6 #define CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 // Badge text displayed on the sidebar's mini tab. 140 // Badge text displayed on the sidebar's mini tab.
141 string16 badge_text_; 141 string16 badge_text_;
142 142
143 // Icon displayed on the sidebar's mini tab. 143 // Icon displayed on the sidebar's mini tab.
144 scoped_ptr<SkBitmap> icon_; 144 scoped_ptr<SkBitmap> icon_;
145 145
146 // Sidebar's title, displayed as a tooltip for sidebar's mini tab. 146 // Sidebar's title, displayed as a tooltip for sidebar's mini tab.
147 string16 title_; 147 string16 title_;
148 148
149 // On the first expand sidebar will be automatically navigated to the default 149 // On the first expand sidebar will be automatically navigated to the default
150 // url (specified in the extension manifest), but only if the extension has 150 // page (specified in the extension manifest), but only if the extension has
151 // not explicitly navigated it yet. This variable is set to false on the first 151 // not explicitly navigated it yet. This variable is set to false on the first
152 // sidebar navigation. 152 // sidebar navigation.
153 bool navigate_to_default_url_on_expand_; 153 bool navigate_to_default_page_on_expand_;
154 // Since the default icon (specified in the extension manifest) is loaded 154 // Since the default icon (specified in the extension manifest) is loaded
155 // asynchronously, sidebar icon can already be set by the extension 155 // asynchronously, sidebar icon can already be set by the extension
156 // by the time it's loaded. This variable tracks whether the loaded default 156 // by the time it's loaded. This variable tracks whether the loaded default
157 // icon should be used or discarded. 157 // icon should be used or discarded.
158 bool use_default_icon_; 158 bool use_default_icon_;
159 159
160 // Helper to load icons from extension asynchronously. 160 // Helper to load icons from extension asynchronously.
161 scoped_ptr<ImageLoadingTracker> image_loading_tracker_; 161 scoped_ptr<ImageLoadingTracker> image_loading_tracker_;
162 162
163 DISALLOW_COPY_AND_ASSIGN(SidebarContainer); 163 DISALLOW_COPY_AND_ASSIGN(SidebarContainer);
164 }; 164 };
165 165
166 #endif // CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_ 166 #endif // CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_sidebar_api.cc ('k') | chrome/browser/sidebar/sidebar_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698