chrome/test/data/extensions/manifest_tests/sidebar_icon_empty.json - Issue 6378009: Only allow extension pages to be displayed in the sidebar to be consistent...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/manifest_tests/sidebar_icon_empty.json

Issue 6378009: Only allow extension pages to be displayed in the sidebar to be consistent... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/extension.cc ('K') | « chrome/test/data/extensions/manifest_tests/sidebar_external_url.json ('k') | chrome/test/data/extensions/manifest_tests/sidebar_icon_invalid_type.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "name": "test",	2 "name": "test",

3 "version": "1",	3 "version": "1",

4 "sidebar": {	4 "sidebar": {

5 "default_title": "Default title",

6 "default_icon": ""	5 "default_icon": ""

7 },	6 },

8 "permissions": [	7 "permissions": [

9 "experimental"	8 "experimental"

10 ]	9 ]

11 }	10 }

OLD	NEW