Issue 6378008: Add GetScreenMode() to status_area_host.h.

Issue 6378008: Add GetScreenMode() to status_area_host.h. (Closed)

Created:
9 years, 11 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add GetScreenMode() to status_area_host.h. Add GetScreenMode() to status_area_host.h, and remove IsBrowserMode() and IsScreenLockerMode() APIs. The old APIs seem to be a bit confusing since only 3 combinations out of 2^2 are valid. (I mean, IsBrowserMode() == true and IsScreenLockerMode() == true is invalid.) BUG=chromium-os:8386 TEST=manually, try bot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72120

Patch Set 1 : review #

Total comments: 2

Patch Set 2 : review fix #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -53 lines)			Patch
M	chrome/browser/chromeos/frame/browser_view.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/frame/browser_view.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/background_view.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/background_view.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/keyboard_switch_menu.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/status/input_method_menu.h	View		3 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/status/input_method_menu.cc	View		6 chunks	+10 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/status/input_method_menu_button.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/status_area_host.h	View	1	1 chunk	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

LGTM. Thank you for the refactoring. http://codereview.chromium.org/6378008/diff/2001/chrome/browser/chromeos/status/status_area_host.h File chrome/browser/chromeos/status/status_area_host.h (right): http://codereview.chromium.org/6378008/diff/2001/chrome/browser/chromeos/status/status_area_host.h#newcode41 chrome/browser/chromeos/status/status_area_host.h:41: enum ScreenMode { ...

9 years, 11 months ago (2011-01-21 07:59:33 UTC) #2

Yusuke Sato

9 years, 11 months ago (2011-01-21 09:51:26 UTC) #3

fixed. submitting.

http://codereview.chromium.org/6378008/diff/2001/chrome/browser/chromeos/stat...
File chrome/browser/chromeos/status/status_area_host.h (right):

http://codereview.chromium.org/6378008/diff/2001/chrome/browser/chromeos/stat...
chrome/browser/chromeos/status/status_area_host.h:41: enum ScreenMode {
On 2011/01/21 07:59:33, satorux1 wrote:
> Please add a comment about the enum type.

Done.

Expand Messages | Collapse Messages