chrome/browser/sync/resources/setting_up.html - Issue 6378006: Add Throbber control for DOMUI. Use it everywhere in options and in Sync setup UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/resources/setting_up.html

Issue 6378006: Add Throbber control for DOMUI. Use it everywhere in options and in Sync setup UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: - Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/resources/setting_up.html

diff --git a/chrome/browser/sync/resources/setting_up.html b/chrome/browser/sync/resources/setting_up.html

index 02f5bd3157b6b236ffd3d8cfcca9ccc1aed311ea..06d126262553dcdde4966c0eafbf07a06dc81816 100644

--- a/chrome/browser/sync/resources/setting_up.html

+++ b/chrome/browser/sync/resources/setting_up.html

@@ -36,13 +36,8 @@ html[os='mac'] input[type='button'],

html[os='mac'] input[type='submit'] {

font-size: 12pt;

}

-#throb {

- background-image: url("../../../../app/resources/throbber.png");

- width: 16px;

- height: 16px;

- background-position: 0px;

+#throbber {

margin: -3px 10px;

- display: inline-block;

}

#setting_up {

margin: 100px;

@@ -55,23 +50,19 @@ html[os='mac'] input[type='submit'] {

}

</style>

+<link rel="stylesheet" href="chrome://resources/css/throbber.css">

+<script src="chrome://resources/js/cr/ui.js"></script>

+<script src="chrome://resources/js/cr/ui/throbber.js">

+<script src="chrome://resources/js/util.js"></script>

- function advanceThrobber() {

- var throbber = document.getElementById('throb');

- throbber.style.backgroundPositionX =

- ((parseInt(getComputedStyle(throbber).backgroundPositionX) - 16) %

- 576) + 'px';

- }

- setInterval(advanceThrobber, 30);

+ cr.ui.Throbber.decorate($('throbber'));

</script>

</head>

- <span id="throbber_container">

- <span id="throb"></span>

- </span>

+ <div id="throbber" class="throbber"></div>

</div>

« chrome/browser/resources/shared/js/cr/ui/throbber.js ('K') | « chrome/browser/sync/resources/gaia_login.html ('k') | no next file » | no next file with comments »