Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3568)

Unified Diff: chrome/browser/resources/options/clear_browser_data_overlay.js

Issue 6378006: Add Throbber control for DOMUI. Use it everywhere in options and in Sync setup UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: - Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/clear_browser_data_overlay.js
diff --git a/chrome/browser/resources/options/clear_browser_data_overlay.js b/chrome/browser/resources/options/clear_browser_data_overlay.js
index ceb5eaff5ec03040eea1b57ddd965c3f46b5de09..a9516f1e7fde838369d209f50e1380b5bcf6a04b 100644
--- a/chrome/browser/resources/options/clear_browser_data_overlay.js
+++ b/chrome/browser/resources/options/clear_browser_data_overlay.js
@@ -56,6 +56,8 @@ cr.define('options', function() {
$('clearBrowserDataCommit').onclick = function(event) {
chrome.send('performClearBrowserData');
};
+
+ cr.ui.Throbber.decorate($('cbdThrobber'));
},
// Set the enabled state of the commit button.
@@ -84,26 +86,12 @@ cr.define('options', function() {
$('deletePasswordsCheckbox').disabled = state;
$('deleteFormDataCheckbox').disabled = state;
$('clearBrowserDataTimePeriod').disabled = state;
- $('cbdThrobber').style.visibility = state ? 'visible' : 'hidden';
+ $('cbdThrobber').visible = state;
if (state)
$('clearBrowserDataCommit').disabled = true;
else
ClearBrowserDataOverlay.getInstance().updateCommitButtonState_();
-
- function advanceThrobber() {
- var throbber = $('cbdThrobber');
- // TODO(csilv): make this smoother using time-based animation?
- throbber.style.backgroundPositionX =
- ((parseInt(getComputedStyle(throbber).backgroundPositionX, 10) - 16) %
- 576) + 'px';
- }
- if (state) {
- ClearBrowserDataOverlay.throbIntervalId =
- setInterval(advanceThrobber, 30);
- } else {
- clearInterval(ClearBrowserDataOverlay.throbIntervalId);
- }
};
ClearBrowserDataOverlay.setClearLocalDataLabel = function(label) {

Powered by Google App Engine
This is Rietveld 408576698