chrome/browser/sync/resources/gaia_login.html - Issue 6378006: Add Throbber control for DOMUI. Use it everywhere in options and in Sync setup UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/resources/gaia_login.html

Issue 6378006: Add Throbber control for DOMUI. Use it everywhere in options and in Sync setup UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed nit Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/resources/gaia_login.html

diff --git a/chrome/browser/sync/resources/gaia_login.html b/chrome/browser/sync/resources/gaia_login.html

index ff0defe5b0d585634f4a8884b913e7a08a06ba36..2bbab519ff9624b0e7d54f5937b8c1c50ac8206c 100644

--- a/chrome/browser/sync/resources/gaia_login.html

+++ b/chrome/browser/sync/resources/gaia_login.html

@@ -58,11 +58,7 @@

width: 200px;

height: 70px;

}

- #throb {

- background-image: url("../../../../app/resources/throbber.png");

- width: 16px;

- height: 16px;

- background-position: 0px;

+ #logging_in_throbber {

margin: 0px 10px 0px 10px;

}

.toppageverticalspace {

@@ -120,6 +116,7 @@

text-align: center;

}

</style>

+<link rel="stylesheet" href="chrome://resources/css/throbber.css">

</head>

<body bgcolor="#ffffff" vlink="#666666"

i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"

@@ -168,15 +165,10 @@

}

- function advanceThrobber() {

- var throbber = document.getElementById('throb');

- throbber.style.backgroundPositionX =

- ((parseInt(getComputedStyle(throbber).backgroundPositionX) - 16) %

- 576) + 'px';

- }

function showGaiaLogin(args) {

- document.getElementById('throbber_container').style.display = "none";

+ document.getElementById('logging_in_throbber').style.display = "none";

document.getElementById('Email').disabled = false;

document.getElementById('Passwd').disabled = false;

@@ -288,13 +280,11 @@

}

acct_text.textContent = translated_text.replace('Google','');

}

- setInterval(advanceThrobber, 30);

var args = JSON.parse(chrome.dialogArguments);

showGaiaLogin(args);

}

function sendCredentialsAndClose() {

if (!setErrorVisibility())

return false;

@@ -303,8 +293,8 @@

document.getElementById('CaptchaValue').disabled = true;

document.getElementById('AccessCode').disabled = true;

- var throbber = document.getElementById('throbber_container');

- throbber.style.display = "inline";

+ document.getElementById('logging_in_throbber').style.display = "block";

var f = document.getElementById("gaia_loginform");

var result = JSON.stringify({"user" : f.Email.value,

"pass" : f.Passwd.value,

@@ -548,10 +538,7 @@

<tr>

<td>

- <div id="throbber_container" style="display:none;">

- <div id="throb">

- </div>

+ <div id="logging_in_throbber" class="throbber"></div>

</td>

<input id="signIn" type="submit" class="gaia le button"

« no previous file with comments | « chrome/browser/resources/shared_resources.grd ('k') | chrome/browser/sync/resources/setting_up.html » ('j') | no next file with comments »