Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 6377011: wstring: use a few more FilePaths to remove Hack functions (Closed)

Created:
9 years, 11 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

wstring: use a few more FilePaths to remove Hack functions BUG=69467 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72728

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed #

Patch Set 3 : fix2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -68 lines) Patch
M chrome/installer/util/copy_tree_work_item.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 1 13 chunks +60 lines, -48 lines 0 comments Download
M chrome/installer/util/work_item.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/util/work_item.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/util/work_item_list.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
I tried to find an owner of this code but it's all over the place. ...
9 years, 11 months ago (2011-01-26 20:54:39 UTC) #1
Avi (use Gerrit)
http://codereview.chromium.org/6377011/diff/1/chrome/installer/util/work_item.h File chrome/installer/util/work_item.h (right): http://codereview.chromium.org/6377011/diff/1/chrome/installer/util/work_item.h#newcode68 chrome/installer/util/work_item.h:68: const FilePath& alternative_path = FilePath()); How many callers does ...
9 years, 11 months ago (2011-01-26 22:00:31 UTC) #2
Evan Martin
On 2011/01/26 22:00:31, Avi wrote: > chrome/installer/util/work_item.h:68: const FilePath& alternative_path = > FilePath()); > How ...
9 years, 11 months ago (2011-01-26 22:14:11 UTC) #3
Avi (use Gerrit)
Much better. LGTM
9 years, 11 months ago (2011-01-26 22:20:59 UTC) #4
tfarina
9 years, 11 months ago (2011-01-26 22:34:31 UTC) #5
On 2011/01/26 22:20:59, Avi wrote:
> Much better. LGTM

LGTM. Thanks.

Powered by Google App Engine
This is Rietveld 408576698