Issue 6377010: Removed suppressions for leaks caused by CL 6285002, and fixed in CL 6268014.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6377010: Removed suppressions for leaks caused by CL 6285002, and fixed in CL 6268014. (Closed)

Created:
9 years, 11 months ago by ahendrickson

Modified:
9 years, 7 months ago

Reviewers:
Nico, eroman

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

BUG=70782 TEST=Valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72640

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -68 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -68 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

9 years, 11 months ago (2011-01-26 16:27:07 UTC) #2

LG

On Wed, Jan 26, 2011 at 8:25 AM,  <ahendrickson@chromium.org> wrote:
> Reviewers: Nico, eroman,
>
> Description:
>
> BUG=70782
> TEST=Valgrind
>
> Please review this at http://codereview.chromium.org/6377010/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
>
22749e988e1dab96837d054e201d3eee62eb0239..4fc605b74dd255244838bbebde475acc5b3f967f
> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -3644,74 +3644,6 @@
>    fun:_ZN9talk_base6Thread15ProcessMessagesEi
>  }
>  {
> -   bug_70782
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN15SyncSetupWizardC1EP18ProfileSyncService
> -}
> -{
> -   bug_70782_b
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN15SyncSetupWizardC2EP18ProfileSyncService
> -   fun:_ZN15SyncSetupWizardC1EP18ProfileSyncService
> -}
> -{
> -   bug_70782_c
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN25SharedResourcesDataSource8RegisterEv
> -}
> -{
> -   bug_70782_d
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN14PrintPreviewUIC1EP11TabContents
> -}
> -{
> -   bug_70782_d_2
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN14PrintPreviewUIC2EP11TabContents
> -   fun:_ZN14PrintPreviewUIC1EP11TabContents
> -}
> -{
> -   bug_70782_e
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN8NewTabUIC1EP11TabContents
> -}
> -{
> -   bug_70782_f
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN8NewTabUI19InitializeCSSCachesEv
> -}
> -{
> -   bug_70782_g
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN18MostVisitedHandler6AttachEP5DOMUI
> -}
> -{
> -   bug_70782_h
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN12FileBrowseUIC1EP11TabContents
> -}
> -{
> -   bug_70782_i
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN9OptionsUIC1EP11TabContents
> -}
> -{
> -   bug_70782_j
> -   Memcheck:Leak
> -   fun:_Znw*
> -
>
fun:_ZN27ExtensionFunctionDispatcherC1EP14RenderViewHostPNS_8DelegateEPK9ExtensionRK4GURL
> -}
> -{
>    bug_70825
>    Memcheck:Addr1
>    fun:_ZNK3net10UploadData10is_chunkedEv
>
>
>

Expand Messages | Collapse Messages