Issue 6377003: Read services customization manifest on FILE thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6377003: Read services customization manifest on FILE thread (Closed)

Created:
9 years, 11 months ago by Dmitry Polukhin

Modified:
9 years, 7 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Read services customization manifest on FILE thread BUG=chromium-os:11103 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72318

Patch Set 2 : vlog #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -12 lines)			Patch
	M	chrome/browser/chromeos/login/apply_services_customization.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/login/apply_services_customization.cc	View	1	5 chunks	+32 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

LGTM http://codereview.chromium.org/6377003/diff/1/chrome/browser/chromeos/login/apply_services_customization.cc File chrome/browser/chromeos/login/apply_services_customization.cc (right): http://codereview.chromium.org/6377003/diff/1/chrome/browser/chromeos/login/apply_services_customization.cc#newcode135 chrome/browser/chromeos/login/apply_services_customization.cc:135: LOG(ERROR) << "Failed to load services customization manifest ...

9 years, 11 months ago (2011-01-21 12:38:01 UTC) #2

Dmitry Polukhin

9 years, 11 months ago (2011-01-21 15:33:54 UTC) #3

http://codereview.chromium.org/6377003/diff/1/chrome/browser/chromeos/login/a...
File chrome/browser/chromeos/login/apply_services_customization.cc (right):

http://codereview.chromium.org/6377003/diff/1/chrome/browser/chromeos/login/a...
chrome/browser/chromeos/login/apply_services_customization.cc:135: LOG(ERROR) <<
"Failed to load services customization manifest from: "
On 2011/01/21 12:38:01, Nikita Kostylev wrote:
> nit: we should not log error in that case.
> Absent manifest is ok.

Changed to VLOG(1).

Expand Messages | Collapse Messages

Issue 6377003: Read services customization manifest on FILE thread (Closed)

Description

Patch Set 1 #

Patch Set 2 : vlog #

Messages