Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6377001: [Mac] Organize all infobar files into chrome/browser/ui/cocoa/infobars/.... (Closed)

Created:
9 years, 11 months ago by Robert Sesek
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

[Mac] Organize all infobar files into chrome/browser/ui/cocoa/infobars/. BUG=none TEST=compile R=rohitrao Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71671

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1742 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_infobar_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/infobar.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/cocoa/infobar_container_controller.h View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/ui/cocoa/infobar_container_controller.mm View 1 chunk +0 lines, -230 lines 0 comments Download
D chrome/browser/ui/cocoa/infobar_container_controller_unittest.mm View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/ui/cocoa/infobar_controller.h View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/ui/cocoa/infobar_controller.mm View 1 chunk +0 lines, -537 lines 0 comments Download
D chrome/browser/ui/cocoa/infobar_controller_unittest.mm View 1 chunk +0 lines, -284 lines 0 comments Download
D chrome/browser/ui/cocoa/infobar_gradient_view.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/cocoa/infobar_gradient_view.mm View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/ui/cocoa/infobar_gradient_view_unittest.mm View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/ui/cocoa/infobar_test_helper.h View 1 chunk +0 lines, -165 lines 0 comments Download
A chrome/browser/ui/cocoa/infobars/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/ui/cocoa/infobars/infobar.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/infobars/infobar_container_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/infobars/infobar_controller.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/cocoa/infobars/infobar_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/infobars/infobar_gradient_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/infobars/infobar_gradient_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/infobars/infobar_test_helper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_infobar_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_infobar_base.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_infobar_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Robert Sesek
9 years, 11 months ago (2011-01-18 15:46:49 UTC) #1
rohitrao (ping after 24h)
LGTM, with one OWNERS typo. Have you run this through the trybots? http://codereview.chromium.org/6377001/diff/15001/chrome/browser/ui/cocoa/infobars/OWNERS File chrome/browser/ui/cocoa/infobars/OWNERS ...
9 years, 11 months ago (2011-01-18 17:15:54 UTC) #2
Robert Sesek
9 years, 11 months ago (2011-01-18 17:19:05 UTC) #3 
On 2011/01/18 17:15:54, rohitrao wrote:
> LGTM, with one OWNERS typo.  Have you run this through the trybots?

Yes. It didn't attach the results though.
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/9142

http://codereview.chromium.org/6377001/diff/15001/chrome/browser/ui/cocoa/inf...
File chrome/browser/ui/cocoa/infobars/OWNERS (right):

http://codereview.chromium.org/6377001/diff/15001/chrome/browser/ui/cocoa/inf...
chrome/browser/ui/cocoa/infobars/OWNERS:1: rohitrao@chromiu.org
On 2011/01/18 17:15:54, rohitrao wrote:
> Missing an "m."  

Oops. Done.

Powered by Google App Engine
This is Rietveld 408576698