Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 6376010: appp: Remove tween.h header file. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

appp: Remove tween.h header file. It seems this file was left when all the other animation files were moved to ui/base/animation/. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -44 lines) Patch
D app/tween.h View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Please, take a look.
9 years, 11 months ago (2011-01-24 18:24:29 UTC) #1
Ben Goodger (Google)
9 years, 11 months ago (2011-01-24 19:29:09 UTC) #2
Lgtm thanks

On Monday, January 24, 2011,  <tfarina@chromium.org> wrote:
> Reviewers: Ben Goodger,
>
> Message:
> Please, take a look.
>
> Description:
> appp: Remove tween.h header file.
>
> It seems this file was left when all the other animation files were moved
> to ui/base/animation/.
>
> BUG=None
> TEST=trybots
>
> Please review this at http://codereview.chromium.org/6376010/
>
> Affected files:
>   D app/tween.h
>
>
> Index: app/tween.h
> diff --git a/app/tween.h b/app/tween.h
> deleted file mode 100644
> index
8909906d54fcf3bfff7652e0f2587eb9666b6ce1..0000000000000000000000000000000000000000
> --- a/app/tween.h
> +++ /dev/null
> @@ -1,44 +0,0 @@
> -// Copyright (c) 2010 The Chromium Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style license that can be
> -// found in the LICENSE file.
> -
> -#ifndef APP_TWEEN_H_
> -#define APP_TWEEN_H_
> -#pragma once
> -
> -#include "base/basictypes.h"
> -
> -namespace gfx {
> -class Rect;
> -}
> -
> -class Tween {
> - public:
> -  enum Type {
> -    LINEAR,        // Linear.
> -    EASE_OUT,      // Fast in, slow out (default).
> -    EASE_IN,       // Slow in, fast out.
> -    EASE_IN_OUT,   // Slow in and out, fast in the middle.
> -    FAST_IN_OUT,   // Fast in and out, slow in the middle.
> -    EASE_OUT_SNAP, // Fast in, slow out, snap to final value.
> -    ZERO,          // Returns a value of 0 always.
> -  };
> -
> -  // Returns the value based on the tween type. |state| is from 0-1.
> -  static double CalculateValue(Type type, double state);
> -
> -  // Conveniences for getting a value between a start and end point.
> -  static double ValueBetween(double value, double start, double target);
> -  static int ValueBetween(double value, int start, int target);
> -  static gfx::Rect ValueBetween(double value,
> -                                const gfx::Rect& start_bounds,
> -                                const gfx::Rect& target_bounds);
> -
> - private:
> -  Tween();
> -  ~Tween();
> -
> -  DISALLOW_COPY_AND_ASSIGN(Tween);
> -};
> -
> -#endif  // APP_TWEEN_H_
>
>
>

Powered by Google App Engine
This is Rietveld 408576698