Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/platform-win32.cc

Issue 6376003: Fix possibly wrong use of strncpy_s (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1456 matching lines...) Expand 10 before | Expand all | Expand 10 after
1467 } 1467 }
1468 1468
1469 1469
1470 Thread::Thread(const char* name) : ThreadHandle(ThreadHandle::INVALID) { 1470 Thread::Thread(const char* name) : ThreadHandle(ThreadHandle::INVALID) {
1471 data_ = new PlatformData(kNoThread); 1471 data_ = new PlatformData(kNoThread);
1472 set_name(name); 1472 set_name(name);
1473 } 1473 }
1474 1474
1475 1475
1476 void Thread::set_name(const char* name) { 1476 void Thread::set_name(const char* name) {
1477 strncpy_s(name_, name, sizeof(name_)); 1477 OS::StrNCpy(Vector<char>(name_, sizeof(name_)), name, strlen(name));
1478 name_[sizeof(name_) - 1] = '\0'; 1478 name_[sizeof(name_) - 1] = '\0';
1479 } 1479 }
1480 1480
1481 1481
1482 // Close our own handle for the thread. 1482 // Close our own handle for the thread.
1483 Thread::~Thread() { 1483 Thread::~Thread() {
1484 if (data_->thread_ != kNoThread) CloseHandle(data_->thread_); 1484 if (data_->thread_ != kNoThread) CloseHandle(data_->thread_);
1485 delete data_; 1485 delete data_;
1486 } 1486 }
1487 1487
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
1933 1933
1934 // Release the thread handles 1934 // Release the thread handles
1935 CloseHandle(data_->sampler_thread_); 1935 CloseHandle(data_->sampler_thread_);
1936 CloseHandle(data_->profiled_thread_); 1936 CloseHandle(data_->profiled_thread_);
1937 } 1937 }
1938 1938
1939 1939
1940 #endif // ENABLE_LOGGING_AND_PROFILING 1940 #endif // ENABLE_LOGGING_AND_PROFILING
1941 1941
1942 } } // namespace v8::internal 1942 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698