Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: chrome/browser/resources/options/options_page.js

Issue 6375006: dom-ui settings: Don't allow click sub-page closing when an overlay is visibl... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/options_page.js
===================================================================
--- chrome/browser/resources/options/options_page.js (revision 71996)
+++ chrome/browser/resources/options/options_page.js (working copy)
@@ -382,6 +382,10 @@
if (!(topPage && topPage.parentPage))
return;
+ // If an overlay is currently visible, do nothing.
+ if (this.isOverlayVisible_())
+ return;
+
// If the click was within a subpage, do nothing.
for (var level = 1; level <= 2; level++) {
if ($('subpage-sheet-container-' + level).contains(event.target))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698