Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 6375006: dom-ui settings: Don't allow click sub-page closing when an overlay is visibl... (Closed)

Created:
9 years, 11 months ago by csilv
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

dom-ui settings: Don't allow click sub-page closing when an overlay is visible. BUG=none TEST=Verify clicks don't close sub-pages when an overlay is visible. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/options/options_page.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
csilv
+jhawkins for review.
9 years, 11 months ago (2011-01-20 22:40:45 UTC) #1
James Hawkins
9 years, 11 months ago (2011-01-20 22:43:43 UTC) #2
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698