write_tegra_bios replaces the numerous burn-u-boot scripts.

write_tegra_bios replaces the numerous burn-u-boot scripts.

This tool uses the overlay list to find the board specific
files needed to write a new BIOS image to a tegra board.

Change-Id: I31793062c383ffa351b76b80882f8d69c2fce560

BUG=None
TEST=flash U-Boot on all tegra boards (with some changes to the burn-u-boot directories).

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6112ccc

[vb, 2011-01-27 21:43:15]

http://codereview.chromium.org/6374016/diff/1/host/write_tegra_bios
File host/write_tegra_bios (right):

http://codereview.chromium.org/6374016/diff/1/host/write_tegra_bios#newcode11
host/write_tegra_bios:11: # Include common CrOS utilities.
you might want to 

set -e

to be on the safe side.

http://codereview.chromium.org/6374016/diff/1/host/write_tegra_bios#newcode65
host/write_tegra_bios:65: if ! which nvflash >/dev/null ; then
can this check be done before further processing, somewhere in line 45?

http://codereview.chromium.org/6374016/diff/1/host/write_tegra_bios#newcode94
host/write_tegra_bios:94: trap "rm -f ${temp}" EXIT
could this be moved to the point before the file creation is attempted?

[robotboy, 2011-01-27 22:30:41]

Done, PTAL.

http://codereview.chromium.org/6374016/diff/1/host/write_tegra_bios
File host/write_tegra_bios (right):

http://codereview.chromium.org/6374016/diff/1/host/write_tegra_bios#newcode11
host/write_tegra_bios:11: # Include common CrOS utilities.
Done, but I put it below the command line parsing because other scripts do that
and claim that you have to because shflags can cause problems otherwise.

http://codereview.chromium.org/6374016/diff/1/host/write_tegra_bios#newcode65
host/write_tegra_bios:65: if ! which nvflash >/dev/null ; then
It could,, I moved it here because of your previous request.  But I don't see
that it matters much if this happens first, or if checking for burn-u-boot
happens first.

http://codereview.chromium.org/6374016/diff/1/host/write_tegra_bios#newcode94
host/write_tegra_bios:94: trap "rm -f ${temp}" EXIT
On 2011/01/27 21:43:15, vb wrote:
> could this be moved to the point before the file creation is attempted?

Done.

[vb, 2011-01-27 22:36:44]

LGTM

http://codereview.chromium.org/6374016/diff/1/host/write_tegra_bios
File host/write_tegra_bios (right):

http://codereview.chromium.org/6374016/diff/1/host/write_tegra_bios#newcode65
host/write_tegra_bios:65: if ! which nvflash >/dev/null ; then
On 2011/01/27 22:30:41, robotboy wrote:
> It could,, I moved it here because of your previous request.  But I don't see
> that it matters much if this happens first, or if checking for burn-u-boot
> happens first.

I meant moving it before any actual processing starts, but this is not a biggie
either way.

[Kenneth Waters, 2011-01-27 22:46:29]

lgtm.