Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 6374015: Renames secure_hash_nss.cc to secure_hash.cc (Closed)

Created:
9 years, 10 months ago by bulach
Modified:
9 years, 6 months ago
Reviewers:
glotov, wtc
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Renames secure_hash_nss.cc to secure_hash.cc (there's an exclusion for _nss on non-linux platforms, however we need this file for mac and windows as well.) this is a build fix for http://src.chromium.org/viewvc/chrome?view=rev&revision=72782) BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/base.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
A + base/crypto/secure_hash.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bulach
Hi Denis, Hans, would you please take a quick look? I renamed the file so ...
9 years, 10 months ago (2011-01-27 11:44:18 UTC) #1
glotov
LGTM On 2011/01/27 11:44:18, bulach wrote: > Hi Denis, Hans, would you please take a ...
9 years, 10 months ago (2011-01-27 11:47:29 UTC) #2
bulach
thanks! landing it now..
9 years, 10 months ago (2011-01-27 11:54:32 UTC) #3
wtc
LGTM. Would you prefer secure_hash_builtin.cc or secure_hash_default.cc?
9 years, 10 months ago (2011-01-27 17:56:41 UTC) #4
bulach
I can certainly do that. should I also rename sha2.cc? I think "default" sounds better ...
9 years, 10 months ago (2011-01-27 18:01:59 UTC) #5
wtc
9 years, 10 months ago (2011-01-27 18:12:48 UTC) #6
Using "_default" is fine.

Let's not rename sha2.cc because that file name comes from NSS (sha2.c,
originally a C file).

Powered by Google App Engine
This is Rietveld 408576698