Issue 6374012: Fix text padding in the notification dialog for Instant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6374012: Fix text padding in the notification dialog for Instant. (Closed)

Created:
9 years, 11 months ago by kochi

Modified:
9 years, 7 months ago

Reviewers:
Takayoshi Kochi (Google), James Hawkins, satorux1

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/resources/options

Visibility:
Public.

Description

Fix text padding in the notification dialog for Instant. BUG=chromium-os:11244 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72474

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/browser_options_page.css	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kochi

Fixed screenshot is in the bug description (http://crosbug.com/11244 )

9 years, 11 months ago (2011-01-25 07:37:30 UTC) #1

satorux1

LGTM. The screenshot in the issue tracker is very helpful. :) On 2011/01/25 07:37:30, Takayoshi ...

9 years, 11 months ago (2011-01-25 07:43:51 UTC) #2

James Hawkins

On 2011/01/25 07:43:51, satorux1 wrote: > LGTM. The screenshot in the issue tracker is very ...

9 years, 11 months ago (2011-01-25 17:37:25 UTC) #3

Takayoshi Kochi (Google)

9 years, 11 months ago (2011-01-26 08:15:49 UTC) #4

Thanks for the correct fix!

On Wed, Jan 26, 2011 at 2:37 AM, <jhawkins@chromium.org> wrote:

> On 2011/01/25 07:43:51, satorux1 wrote:
>
>> LGTM. The screenshot in the issue tracker is very helpful. :)
>>
>
>  On 2011/01/25 07:37:30, Takayoshi Kochi wrote:
>> > Fixed screenshot is in the bug description
>> > (http://crosbug.com/11244 )
>>
>
> The correct fix is to put the content in a div whose class is
> 'content-area'. We
> reimplemented the dialog API and never fixed the CrOS dialogs.
>
>
> http://codereview.chromium.org/6374012/
>



-- 
Takayoshi Kochi

Expand Messages | Collapse Messages