Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6374011: views: Move layout_manager.[cc,h] into layout directory. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

views: Move layout_manager.[cc,h] into layout directory. The other layout files will be moved later. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72507

Patch Set 1 : #

Patch Set 2 : fix bots - include view.h again #

Patch Set 3 : layout-manager #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -37 lines) Patch
M chrome/browser/chromeos/login/eula_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/views/domui_menu_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/instant_confirm_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M views/grid_layout.h View 1 chunk +1 line, -1 line 0 comments Download
M views/layout/box_layout.h View 1 chunk +1 line, -1 line 0 comments Download
M views/layout/fill_layout.h View 1 chunk +1 line, -1 line 0 comments Download
A + views/layout/layout_manager.h View 1 4 chunks +6 lines, -8 lines 3 comments Download
A views/layout/layout_manager.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
D views/layout_manager.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M views/view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M views/views.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M views/widget/widget_win.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Please, take a look.
9 years, 11 months ago (2011-01-25 03:40:21 UTC) #1
sky
http://codereview.chromium.org/6374011/diff/8001/views/layout/layout_manager.h File views/layout/layout_manager.h (left): http://codereview.chromium.org/6374011/diff/8001/views/layout/layout_manager.h#oldcode9 views/layout/layout_manager.h:9: #include "views/view.h" This include should be nuked. http://codereview.chromium.org/6374011/diff/8001/views/layout/layout_manager.h#oldcode17 views/layout/layout_manager.h:17: ...
9 years, 11 months ago (2011-01-25 16:19:12 UTC) #2
tfarina
http://codereview.chromium.org/6374011/diff/8001/views/layout/layout_manager.h File views/layout/layout_manager.h (left): http://codereview.chromium.org/6374011/diff/8001/views/layout/layout_manager.h#oldcode9 views/layout/layout_manager.h:9: #include "views/view.h" On 2011/01/25 16:19:12, sky wrote: > This ...
9 years, 11 months ago (2011-01-25 17:25:20 UTC) #3
sky
9 years, 11 months ago (2011-01-25 17:32:03 UTC) #4 
Sure. LGTM

Powered by Google App Engine
This is Rietveld 408576698