Issue 6374009: Get rid of a few more interfaces from RenderViewHostDelegate that aren't need...

Issue 6374009: Get rid of a few more interfaces from RenderViewHostDelegate that aren't need... (Closed)

Created:
9 years, 11 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Get rid of a few more interfaces from RenderViewHostDelegate that aren't needed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72522

Patch Set 3 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -272 lines)			Patch
M	chrome/browser/download/save_package.h	View	1	5 chunks	+14 lines, -18 lines	0 comments	Download
M	chrome/browser/download/save_package.cc	View	1	2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.h	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	1	3 chunks	+16 lines, -6 lines	0 comments	Download
M	chrome/browser/fav_icon_helper.h	View	1	3 chunks	+10 lines, -11 lines	0 comments	Download
M	chrome/browser/fav_icon_helper.cc	View	1	3 chunks	+16 lines, -8 lines	0 comments	Download
M	chrome/browser/file_select_helper.h	View	1	3 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.h	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.cc	View	1 2	4 chunks	+14 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View	1	3 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1	9 chunks	+0 lines, -70 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View	1	3 chunks	+0 lines, -90 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.cc	View	1	2 chunks	+0 lines, -19 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1	6 chunks	+20 lines, -20 lines	0 comments	Download
M	chrome/test/automation/tab_proxy.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

One question. http://codereview.chromium.org/6374009/diff/31001/chrome/test/automation/tab_proxy.h File chrome/test/automation/tab_proxy.h (right): http://codereview.chromium.org/6374009/diff/31001/chrome/test/automation/tab_proxy.h#newcode27 chrome/test/automation/tab_proxy.h:27: #include "webkit/glue/window_open_disposition.h" This include is used in ...

9 years, 11 months ago (2011-01-25 14:28:33 UTC) #2

jam

http://codereview.chromium.org/6374009/diff/31001/chrome/test/automation/tab_proxy.h File chrome/test/automation/tab_proxy.h (right): http://codereview.chromium.org/6374009/diff/31001/chrome/test/automation/tab_proxy.h#newcode27 chrome/test/automation/tab_proxy.h:27: #include "webkit/glue/window_open_disposition.h" On 2011/01/25 14:28:33, Avi wrote: > This ...

9 years, 11 months ago (2011-01-25 17:38:31 UTC) #3

Gotcha. LGTM

Expand Messages | Collapse Messages