Issue 6374005: DOMUI Prefs: Fix the initial visibility of Search

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6374005: DOMUI Prefs: Fix the initial visibility of Search (Closed)

Created:
9 years, 11 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI Prefs: Fix the initial visibility of Search Don't start with Search visible, since it can cause the code that shows specific sub pages to be confused when prefs are opened to a specific URL, and leave search as the root page. Also fixes an exception during initialization on non-ChromeOS machines. BUG=69613 TEST=Opening prefs to a subpage by URL should show the right parent page, not Search. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71900

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/resources/options/advanced_options.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/resources/options/search_page.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages