Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Side by Side Diff: chrome/browser/in_process_webkit/indexed_db_browsertest.cc

Issue 6374003: Mark IndexedDBBrowserTest.KeyPathTest flaky on windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/file_path.h" 6 #include "base/file_path.h"
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/ref_counted.h" 8 #include "base/ref_counted.h"
9 #include "base/scoped_temp_dir.h" 9 #include "base/scoped_temp_dir.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, CursorTest) { 51 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, CursorTest) {
52 SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("cursor_test.html")))); 52 SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("cursor_test.html"))));
53 } 53 }
54 54
55 // TODO(hans): Keep an eye out for these tests going flaky. See crbug.com/63675. 55 // TODO(hans): Keep an eye out for these tests going flaky. See crbug.com/63675.
56 // Crashy, http://crbug.com/67422. 56 // Crashy, http://crbug.com/67422.
57 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DISABLED_IndexTest) { 57 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DISABLED_IndexTest) {
58 SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("index_test.html")))); 58 SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("index_test.html"))));
59 } 59 }
60 60
61 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, KeyPathTest) { 61 // Flaky on windows, see http://crbug.com/67422 and http://crbug.com/69293.
62 #if defined(OS_WIN)
63 #define MAYBE_KeyPathTest FLAKY_KeyPathTest
64 #else
65 #define MAYBE_KeyPathTest KeyPathTest
66 #endif
67
68 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, MAYBE_KeyPathTest) {
62 SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("key_path_test.html")))); 69 SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("key_path_test.html"))));
63 } 70 }
64 71
65 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, TransactionGetTest) { 72 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, TransactionGetTest) {
66 SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("transaction_get_test.html")))); 73 SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("transaction_get_test.html"))));
67 } 74 }
68 75
69 // Crashy, http://crbug.com/68446. 76 // Crashy, http://crbug.com/68446.
70 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DISABLED_ObjectStoreTest) { 77 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DISABLED_ObjectStoreTest) {
71 SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("object_store_test.html")))); 78 SimpleTest(testUrl(FilePath(FILE_PATH_LITERAL("object_store_test.html"))));
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 // Make sure we wait until the destructor has run. 126 // Make sure we wait until the destructor has run.
120 scoped_refptr<ThreadTestHelper> helper( 127 scoped_refptr<ThreadTestHelper> helper(
121 new ThreadTestHelper(BrowserThread::WEBKIT)); 128 new ThreadTestHelper(BrowserThread::WEBKIT));
122 ASSERT_TRUE(helper->Run()); 129 ASSERT_TRUE(helper->Run());
123 130
124 // Because we specified https for scheme to be skipped the second file 131 // Because we specified https for scheme to be skipped the second file
125 // should survive and the first go into vanity. 132 // should survive and the first go into vanity.
126 ASSERT_FALSE(file_util::PathExists(temp_file_path_1)); 133 ASSERT_FALSE(file_util::PathExists(temp_file_path_1));
127 ASSERT_TRUE(file_util::PathExists(temp_file_path_2)); 134 ASSERT_TRUE(file_util::PathExists(temp_file_path_2));
128 } 135 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698