Issue 6373013: Fix for jankiness in some accelerated 2D canvas demos: If there is already a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6373013: Fix for jankiness in some accelerated 2D canvas demos: If there is already a... (Closed)

Created:
9 years, 11 months ago by Stephen White

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit), greggman

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix for jankiness in some accelerated 2D canvas demos: If there is already a pending call to CopyTextureToParentTextureCHROMIUM, the second will block until the first is consumed (same fix as was done to SwapBuffers for WebGL). [Patch by gman; I just typed. :)] BUG=68735 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72713

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -5 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_autogen.h	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Stephen White

I did some more testing, and it turns out that lowering the kMaxSwapBuffers from 2 ...

9 years, 11 months ago (2011-01-26 21:47:26 UTC) #1

greggman

9 years, 11 months ago (2011-01-27 07:29:23 UTC) #3

LGTM

BTW:I'm putting in fences. My old CL is merged. Need to refactor some gpu_xxx
stuff

Expand Messages | Collapse Messages