Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 6373010: Allow multiple instances of the newer VLC plugins to load. The older versions... (Closed)

Created:
9 years, 11 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Allow multiple instances of the newer VLC plugins to load. The older versions had bugs which would cause crashes if multiple instances were loaded. Fixes bug http://code.google.com/p/chromium/issues/detail?id=70602 BUG=70602 TEST=As described in the bug report. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72434

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 1 5 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
9 years, 11 months ago (2011-01-24 22:06:38 UTC) #1
jam
http://codereview.chromium.org/6373010/diff/1/webkit/plugins/npapi/webplugin_delegate_impl_win.cc File webkit/plugins/npapi/webplugin_delegate_impl_win.cc (right): http://codereview.chromium.org/6373010/diff/1/webkit/plugins/npapi/webplugin_delegate_impl_win.cc#newcode185 webkit/plugins/npapi/webplugin_delegate_impl_win.cc:185: int major_version = 0; i think we want to ...
9 years, 11 months ago (2011-01-24 22:38:35 UTC) #2
jam
9 years, 11 months ago (2011-01-24 23:22:18 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698