Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 6372008: Make sure the process is _really_ gone after a __debugbreak(). We've had a... (Closed)

Created:
9 years, 11 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
Cris Neckar
CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Make sure the process is _really_ gone after a __debugbreak(). We've had a few annoying cases where someone has been monitoring Chrome under windbg, which can skip over __debugbreak() and then show them a scary-looking access violation. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72107

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M base/debug/debugger_posix.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M base/debug/debugger_win.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/chrome_main.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/plugin/plugin_main.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Evans
As discussed.
9 years, 11 months ago (2011-01-20 22:33:45 UTC) #1
Cris Neckar
LGTM
9 years, 11 months ago (2011-01-20 22:35:56 UTC) #2
Chris Evans
On 2011/01/20 22:35:56, cdn wrote: > LGTM PTAL? Added changes to the BreakDebugger() methods, which ...
9 years, 11 months ago (2011-01-21 00:12:59 UTC) #3
Cris Neckar
9 years, 11 months ago (2011-01-21 00:52:25 UTC) #4
This seems to work on windows as well

LGTM

Powered by Google App Engine
This is Rietveld 408576698