Issue 6372003: Fixes problem with non-consitent active downloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6372003: Fixes problem with non-consitent active downloads. (Closed)

Created:
9 years, 11 months ago by altimofeev

Modified:
9 years, 7 months ago

Reviewers:
xiyuan, achuithb

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes problem with non-consitent active downloads. Fix http://src.chromium.org/viewvc/chrome?view=rev&revision=71785 revealed possible flow, when active downloads list contains non-existing downloads. This fix removes redundant method call, which is also dangerous. BUG=none TEST=cancel dangerous download, notice that Chromium is alive. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72121

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/browser/dom_ui/filebrowse_ui.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

LGTM.

On 2011/01/20 17:13:56, xiyuan wrote:
> LGTM