Ensures that GDB prints stacktraces correctly for x64 builds when debugging t...

src/x64/virtual-frame-x64.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 12 matching lines @@
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include "v8.h"
 
 #if defined(V8_TARGET_ARCH_X64)
 
 #include "codegen-inl.h"
+#include "gdb-jit.h"
 #include "register-allocator-inl.h"
 #include "scopes.h"
 #include "stub-cache.h"
 #include "virtual-frame-inl.h"
 
 namespace v8 {
 namespace internal {
 
 #define __ ACCESS_MASM(masm())
 
@@ skipping 13 matching lines @@
     Condition not_smi = NegateCondition(masm()->CheckSmi(rdi));
     __ Check(not_smi,
              "VirtualFrame::Enter - rdi is not a function (smi check).");
     __ CmpObjectType(rdi, JS_FUNCTION_TYPE, rax);
     __ Check(equal,
              "VirtualFrame::Enter - rdi is not a function (map check).");
   }
 #endif
 
   EmitPush(rbp);
+  SET_UNWIND_INFO(UNWIND_STATE_AFTER_RBP_PUSH, masm()->pc_offset());

[Vyacheslav Egorov (Chromium), 2011/01/25 12:50:11]

The classic codegen is going to be replaced with Crankshaft codegen in the
future.

We think there is no need to change it.

People can run with --always-full-compiler to get debugging information for all
code.

 
   __ movq(rbp, rsp);
+  SET_UNWIND_INFO(UNWIND_STATE_AFTER_RBP_SET, masm()->pc_offset());
 
   // Store the context in the frame.  The context is kept in rsi and a
   // copy is stored in the frame.  The external reference to rsi
   // remains.
   EmitPush(rsi);
 
   // Store the function in the frame.  The frame owns the register
   // reference now (ie, it can keep it in rdi or spill it later).
   Push(rdi);
   SyncElementAt(element_count() - 1);
@@ skipping 16 matching lines @@
   __ movq(rsp, rbp);
   stack_pointer_ = frame_pointer();
   for (int i = element_count() - 1; i > stack_pointer_; i--) {
     FrameElement last = elements_.RemoveLast();
     if (last.is_register()) {
       Unuse(last.reg());
     }
   }
 
   EmitPop(rbp);
+  SET_UNWIND_INFO(UNWIND_STATE_AFTER_RBP_POP, masm()->pc_offset());
 }
 
 
 void VirtualFrame::AllocateStackSlots() {
   int count = local_count();
   if (count > 0) {
     Comment cmnt(masm(), "[ Allocate space for locals");
     // The locals are initialized to a constant (the undefined value), but
     // we sync them with the actual frame to allocate space for spilling
     // them later.  First sync everything above the stack pointer so we can
@@ skipping 1142 matching lines @@
   Adjust(kHandlerSize - 1);
   __ PushTryHandler(IN_JAVASCRIPT, type);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_X64