Ensures that GDB prints stacktraces correctly for x64 builds when debugging t...

src/x64/codegen-x64.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2976 matching lines @@
   // Add a label for checking the size of the code used for returning.
 #ifdef DEBUG
   Label check_exit_codesize;
   masm_->bind(&check_exit_codesize);
 #endif
 
   // Leave the frame and return popping the arguments and the
   // receiver.
   frame_->Exit();
   masm_->ret((scope()->num_parameters() + 1) * kPointerSize);
+
+  SET_UNWIND_INFO(UNWIND_STATE_AFTER_RETURN, masm_->pc_offset());
+

[Vyacheslav Egorov (Chromium), 2011/01/25 12:50:11]

Revert this change.

Classic codegen is going to be replaced by Crankshaft in the future so we think
there is no need to support GDBJIT in classic codegen.

People should run with --always-full-compiler if they want --gdbjit (or even
--gdbjit will enable --always-full-compiler by default).

There is some support for line information in codegen.cc that I added but I
think I will just revert that.

   DeleteFrame();
 
 #ifdef ENABLE_DEBUGGER_SUPPORT
   // Add padding that will be overwritten by a debugger breakpoint.
   // frame_->Exit() generates "movq rsp, rbp; pop rbp; ret k"
   // with length 7 (3 + 1 + 3).
   const int kPadding = Assembler::kJSReturnSequenceLength - 7;
   for (int i = 0; i < kPadding; ++i) {
     masm_->int3();
   }
@@ skipping 5791 matching lines @@
 }
 
 #endif
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_X64