Fix the breakage of radio/checkbox click handling on settings overlay.

Fix the breakage of radio/checkbox click handling on settings overlay.

Only eat the event in subPageClosingClickHandler_ if it happens on the narrow strip part.

BUG=chromium-os:11202
TEST=Verify the radio/checkbox on overlay page works again per chromium-os:11202.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72412

[stuartmorgan, 2011-01-24 21:56:54]

Can you elaborate in the CL description as to why exactly this is the fix? This
stops the event in the bubbling phase; why do subpage controls rely on clicks
bubbling through the subpage to work?

[xiyuan, 2011-01-24 22:01:40]

On 2011/01/24 21:56:54, stuartmorgan wrote:
> Can you elaborate in the CL description as to why exactly this is the fix?
This
> stops the event in the bubbling phase; why do subpage controls rely on clicks
> bubbling through the subpage to work?

Currently, 'click' event on radio/checkbox on overlay page reaches in
subPageClosingClickHandler_. And because we now 'preventDefault' on the event
regardlessly, the radio/checkbox does not see it and does not change its value.
You can see the problem in the proxy overlay where radio/checkbox does not work
as in chromium-os:11202.

The fix is to only do 'preventDefault' if the 'click' is on the narrow strip
area.

[stuartmorgan, 2011-01-24 22:26:59]

LGTM

I wasn't aware that preventDefault wasn't specific to the point in the event
flow where it is called.

[stuartmorgan, 2011-01-24 22:27:34]

BTW, please try to get this merged to M10