Issue 6371004: Add missing docstrings and don't copy generated payloads if only pre-generating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6371004: Add missing docstrings and don't copy generated payloads if only pre-generating. (Closed)

Created:
9 years, 11 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Nick Sanders, ericli, DaleCurtis

Base URL:
http://git.chromium.org/git/dev-util.git@master

Visibility:
Public.

Description

Add missing docstrings and don't copy generated payloads if only pre-generating. Change-Id: I621cb23c87f141a5c028e7878b74a720f7e35284 BUG=chromium-os:10723 TEST=Ran with test harness + 4 tests and ran manually with and without --exit and re-ran unittests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=08d55a2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Typo #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	autoupdate.py	View	1	3 chunks	+14 lines, -3 lines	0 comments	Download
	M	devserver.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

9 years, 11 months ago (2011-01-19 23:56:04 UTC) #2

LGTM

http://codereview.chromium.org/6371004/diff/1/autoupdate.py
File autoupdate.py (right):

http://codereview.chromium.org/6371004/diff/1/autoupdate.py#newcode54
autoupdate.py:54: src_image: If specifies, creates a delta payload from this
image.
typoe: specifies

Expand Messages | Collapse Messages