Issue 6371002: [Mac] Organize all import files into chrome/browser/ui/cocoa/importer/....

Issue 6371002: [Mac] Organize all import files into chrome/browser/ui/cocoa/importer/.... (Closed)

Created:
9 years, 11 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Organize all import files into chrome/browser/ui/cocoa/importer/. BUG=none TEST=compiles R=mirandac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71684

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -847 lines)			Patch
M	chrome/browser/app_controller_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/importer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/cocoa/import_progress_dialog.h	View	1 chunk	+0 lines, -102 lines	0 comments	Download
D	chrome/browser/ui/cocoa/import_progress_dialog.mm	View	1 chunk	+0 lines, -192 lines	0 comments	Download
D	chrome/browser/ui/cocoa/import_settings_dialog.h	View	1 chunk	+0 lines, -98 lines	0 comments	Download
D	chrome/browser/ui/cocoa/import_settings_dialog.mm	View	1 chunk	+0 lines, -245 lines	0 comments	Download
D	chrome/browser/ui/cocoa/import_settings_dialog_unittest.mm	View	1 chunk	+0 lines, -130 lines	0 comments	Download
A	chrome/browser/ui/cocoa/importer/OWNERS	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	chrome/browser/ui/cocoa/importer/import_progress_dialog.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/cocoa/importer/import_progress_dialog.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/ui/cocoa/importer/import_settings_dialog.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/cocoa/importer/import_settings_dialog.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/ui/cocoa/importer/import_settings_dialog_unittest.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/ui/cocoa/importer/importer_lock_dialog.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/cocoa/importer/importer_lock_dialog.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/cocoa/importer_lock_dialog.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	chrome/browser/ui/cocoa/importer_lock_dialog.mm	View	1 chunk	+0 lines, -34 lines	0 comments	Download
M	chrome/browser/ui/cocoa/options/preferences_window_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

Forgot to ask: should the first_run_* files go into this importer/ subdir?

9 years, 11 months ago (2011-01-18 18:40:44 UTC) #2

Miranda Callahan

9 years, 11 months ago (2011-01-18 18:46:43 UTC) #3

On 2011/01/18 18:40:44, rsesek wrote:
> Forgot to ask: should the first_run_* files go into this importer/ subdir?

LGTM, and thanks!  My intuition is that first run should not go here, because
first run does more than just organize the import process.

Expand Messages | Collapse Messages