Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 6371001: A quick fix for TopSitesMigrationTest.Migrate... (Closed)

Created:
9 years, 11 months ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
satorux1, sky
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

A quick fix for TopSitesMigrationTest.Migrate. This test seems to fail because history.19.sql migrates very old pages, i.e. pages whose last_visit_time is >90 days before now, and our history service filters them out. This change just replaces the time-sensitive values (i.e. 'last_visit_time', 'visit_time', and 'time_slot') with the current time to prevent migrating expired pages. BUG=none TEST=TopSitesMigrationTest.Migrate Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71588

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M chrome/browser/history/top_sites_unittest.cc View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/test/data/top_sites/history.19.sql View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hironori Bono
Greetings, This change just fixes the said test failure and it may be a good ...
9 years, 11 months ago (2011-01-17 08:43:49 UTC) #1
satorux1
LGTM. Thank you for fixing this! On 2011/01/17 08:43:49, hbono wrote: > Greetings, > > ...
9 years, 11 months ago (2011-01-17 08:54:08 UTC) #2
sky
9 years, 11 months ago (2011-01-18 17:02:51 UTC) #3
LGTM too.
Thanks for fixing.

  -Scott

Powered by Google App Engine
This is Rietveld 408576698