Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6370010: Fix bug where when the 3G data plan is unknown, we show a green 3G badge. We ... (Closed)

Created:
9 years, 11 months ago by Charlie Lee
Modified:
9 years, 7 months ago
Reviewers:
zel
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix bug where when the 3G data plan is unknown, we show a green 3G badge. We now show a grey 3G badge when the data plan is unknown. BUG=chromium-os:9720 TEST=connect/disconnect from 3G. Verify that we transition to state with unknown plans (grey 3G badge). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72371

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
A chrome/app/theme/statusbar_network_1x_unknown.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_3g_unknown.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Lee
9 years, 11 months ago (2011-01-21 23:19:34 UTC) #1
zel
http://codereview.chromium.org/6370010/diff/1/chrome/browser/chromeos/cros/network_library.h File chrome/browser/chromeos/cros/network_library.h (right): http://codereview.chromium.org/6370010/diff/1/chrome/browser/chromeos/cros/network_library.h#newcode225 chrome/browser/chromeos/cros/network_library.h:225: DATA_UNKNOWN I would put initial states as the first ...
9 years, 11 months ago (2011-01-24 19:19:48 UTC) #2
Charlie Lee
http://codereview.chromium.org/6370010/diff/1/chrome/browser/chromeos/cros/network_library.h File chrome/browser/chromeos/cros/network_library.h (right): http://codereview.chromium.org/6370010/diff/1/chrome/browser/chromeos/cros/network_library.h#newcode225 chrome/browser/chromeos/cros/network_library.h:225: DATA_UNKNOWN On 2011/01/24 19:19:48, zel wrote: > I would ...
9 years, 11 months ago (2011-01-24 19:30:13 UTC) #3
zel
9 years, 11 months ago (2011-01-24 19:31:08 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698