Enable session resumption in SSLServerSocketNSS and unit tests

net/socket/ssl_server_socket_nss.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/ssl_server_socket_nss.h"
 
 #if defined(OS_WIN)
 #include <winsock2.h>
 #endif
 
@@ skipping 274 matching lines @@
     LogFailedNSSFunction(net_log_, "SSL_OptionSet", "SSL_REQUEST_CERTIFICATE");
     return ERR_UNEXPECTED;
   }
 
   rv = SSL_OptionSet(nss_fd_, SSL_REQUIRE_CERTIFICATE, PR_FALSE);
   if (rv != SECSuccess) {
     LogFailedNSSFunction(net_log_, "SSL_OptionSet", "SSL_REQUIRE_CERTIFICATE");
     return ERR_UNEXPECTED;
   }
 
-  rv = SSL_OptionSet(nss_fd_, SSL_NO_CACHE, PR_TRUE);
-  if (rv != SECSuccess) {
-    LogFailedNSSFunction(net_log_, "SSL_OptionSet", "SSL_NO_CACHE");
-    return ERR_UNEXPECTED;
-  }
-
   rv = SSL_ConfigServerSessionIDCache(1024, 5, 5, NULL);

[wtc, 2011/01/21 21:32:38]

SSL_ConfigServerSessionIDCache should be called only once by
an application.  (It does allow a repeat call though.)

Please add an EnsureNSSSSLServerInit() function, similar to
the EnsureNSSSSLInit() function, to call
SSL_ConfigServerSessionIDCache.

The ssl2_timeout and ssl3_timeout arguments are in seconds.
5 seconds is too short.  I suggest that you pass 0 so that
the default timeout is used (100 seconds for SSL2, 24 hours
for SSL3).

The default max cache entries is 10000, which is too big for
a client application that acts as an SSL server (for peer to
peer).  So passing a smaller value (1024 or even 128) is a
good idea.

   if (rv != SECSuccess) {
     LogFailedNSSFunction(net_log_, "SSL_ConfigureServerSessionIDCache", "");
     return ERR_UNEXPECTED;
   }
 
   rv = SSL_AuthCertificateHook(nss_fd_, OwnAuthCertHandler, this);
   if (rv != SECSuccess) {
     LogFailedNSSFunction(net_log_, "SSL_AuthCertificateHook", "");
     return ERR_UNEXPECTED;
   }
@@ skipping 362 matching lines @@
                  << ", net_error " << net_error;
       net_log_.AddEvent(
           NetLog::TYPE_SSL_HANDSHAKE_ERROR,
           make_scoped_refptr(new SSLErrorParams(net_error, prerr)));
     }
   }
   return net_error;
 }
 
 }  // namespace net