functional/downloads.py - Issue 6369010: Add additional logging to diagnose flaky testZipInIncognito test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: functional/downloads.py

Issue 6369010: Add additional logging to diagnose flaky testZipInIncognito test (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/test/

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: functional/downloads.py

===================================================================

--- functional/downloads.py (revision 71499)

+++ functional/downloads.py (working copy)

@@ -152,7 +152,10 @@

# Using WaitUntil is the only resort.

self.NavigateToURL(file_url, 1, 0)

self.assertTrue(self.WaitUntil(lambda: os.path.exists(downloaded_pkg)))

- self.assertTrue(self._EqualFileContents(file_path, downloaded_pkg))

+ self.assertTrue(self._EqualFileContents(file_path, downloaded_pkg),

+ msg='%s (size %d) and %s (size %d) do not match' % (

+ file_path, os.path.getsize(file_path),

+ downloaded_pkg, os.path.getsize(downloaded_pkg)))

self.assertTrue(self.IsDownloadShelfVisible(1))

def testSaveDangerousFile(self):

« no previous file with comments | « no previous file | no next file » | no next file with comments »