Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 6369007: Disable enforced throttling for URL requests.... (Closed)

Created:
9 years, 11 months ago by yzshen1
Modified:
9 years, 7 months ago
Reviewers:
Jói
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Disable enforced throttling for URL requests. The throttling feature rejects outbound HTTP requests to a server for a period of time, when it finds that the server is returning 5XX. This change disables the feature. TEST=none BUG=70412 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M net/url_request/url_request_http_job.cc View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yzshen1
9 years, 11 months ago (2011-01-21 17:05:14 UTC) #1
Jói
9 years, 11 months ago (2011-01-21 21:31:25 UTC) #2
LGTM

Thanks Yuzhu.

On Fri, Jan 21, 2011 at 9:05 AM,  <yzshen@chromium.org> wrote:
> Reviewers: Jói,
>
> Description:
> Disable enforced throttling for URL requests.
>
> The throttling feature rejects outbound HTTP requests to a server for a
> period
> of time, when it finds that the server is returning 5XX.
> This change disables the feature.
>
> TEST=none
> BUG=70412
>
>
> Please review this at http://codereview.chromium.org/6369007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     net/url_request/url_request_http_job.cc
>
>
> Index: net/url_request/url_request_http_job.cc
> ===================================================================
> --- net/url_request/url_request_http_job.cc     (revision 72103)
> +++ net/url_request/url_request_http_job.cc     (working copy)
> @@ -219,15 +219,8 @@
>     rv = request_->context()->http_transaction_factory()->CreateTransaction(
>         &transaction_);
>     if (rv == OK) {
> -      if (!throttling_entry_->IsDuringExponentialBackoff() ||
> -          !net::URLRequestThrottlerManager::GetInstance()->
> -              enforce_throttling()) {
> -        rv = transaction_->Start(
> -            &request_info_, &start_callback_, request_->net_log());
> -      } else {
> -        // Special error code for the exponential back-off module.
> -        rv = ERR_TEMPORARILY_THROTTLED;
> -      }
> +      rv = transaction_->Start(
> +          &request_info_, &start_callback_, request_->net_log());
>       // Make sure the context is alive for the duration of the
>       // transaction.
>       context_ = request_->context();
>
>
>

Powered by Google App Engine
This is Rietveld 408576698