Issue 6369006: css changes for clear browsing data page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6369006: css changes for clear browsing data page. (Closed)

Created:
9 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Bernhard Bauer, ainslie, stuartmorgan

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

css changes for clear browsing data page. css from ainslie@ BUG=63843 TEST=visual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71905

Patch Set 1 #

Patch Set 2 : updates #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -8 lines)			Patch
	M	chrome/browser/resources/options/clear_browser_data_overlay.css	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
	M	chrome/browser/resources/options/options_page.css	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ainslie

Three quick updates: 1. Add a bit of space between the ok/cancel buttons: button-strip > ...

9 years, 11 months ago (2011-01-20 00:16:05 UTC) #3

Evan Stade

9 years, 11 months ago (2011-01-20 01:13:26 UTC) #4

On 2011/01/20 00:16:05, ainslie wrote:
> Three quick updates:
> 
> 1. Add a bit of space between the ok/cancel buttons: 
> button-strip > button 
> -webkit-margin-start: 10px;

done.

> 
> 2. Shorten the link text to: 
> Adobe Flash Player local storage ...

bauerb just changed this string within the last week. I'll leave it alone for
now and ping him on if we can shorten it again.

> 
> 3. Give the dialogs a min-width of 500px. 
> (in this case clearBrowserDataOverlay)
> 
> Otherwise LGTM.

done.

Expand Messages | Collapse Messages