Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 6368153: Check return code of fwrite in raw image writing code. (Closed)

Created:
9 years, 10 months ago by robotboy
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Check return code of fwrite in raw image writing code. Change-Id: I8c52a205ae1dc559c9f8b41d4d2c50e821b3b05c BUG=None TEST=None Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7cdc68c

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix tab->space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M data_layout.c View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robotboy
9 years, 10 months ago (2011-02-08 00:31:13 UTC) #1
Micah C
A few nits. What's the larger context for this change? Is there a bug number ...
9 years, 10 months ago (2011-02-08 03:52:46 UTC) #2
robotboy
Done, and questions answered, PTAL. http://codereview.chromium.org/6368153/diff/1/data_layout.c File data_layout.c (right): http://codereview.chromium.org/6368153/diff/1/data_layout.c#newcode1020 data_layout.c:1020: { ANSI C doesn't ...
9 years, 10 months ago (2011-02-08 18:48:00 UTC) #3
micahc
9 years, 10 months ago (2011-02-10 18:27:54 UTC) #4
LGTM as is, thanks for explanation.

If there is any other symbolic constant for an "unspecified error" other than
-1, you might swap that in -- but don't spend much time looking for one.

Powered by Google App Engine
This is Rietveld 408576698