Issue 6368138: Support %_IsConstructCall in Crankshaft pipeline.

Issue 6368138: Support %_IsConstructCall in Crankshaft pipeline. (Closed)

Created:
9 years, 10 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Support %_IsConstructCall in the Crankshaft pipeline. Provide special case for f.bind(obj). Committed: http://code.google.com/p/v8/source/detail?r=6671

Patch Set 1 #

Patch Set 2 : don't check argc_bound twice #

Total comments: 6

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+321 lines, -32 lines)			Patch
M	src/arm/lithium-arm.h	View		2 chunks	+25 lines, -0 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+49 lines, -0 lines	2 comments	Download
M	src/hydrogen.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		2 chunks	+16 lines, -0 lines	1 comment	Download
M	src/ia32/lithium-codegen-ia32.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+47 lines, -0 lines	1 comment	Download
M	src/ia32/lithium-ia32.h	View		2 chunks	+20 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+24 lines, -8 lines	1 comment	Download
M	src/v8natives.js	View	1	1 chunk	+32 lines, -22 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+48 lines, -0 lines	1 comment	Download
M	src/x64/lithium-x64.h	View		2 chunks	+20 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 10 months ago (2011-02-08 07:09:44 UTC) #2

LGTM

http://codereview.chromium.org/6368138/diff/1002/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6368138/diff/1002/src/arm/lithium-codegen-arm....
src/arm/lithium-codegen-arm.cc:3783: Register temp =
ToRegister(instr->TempAt(0));
Instead of allocating a temp here you could use scratch0() which is excluded
from register allocation on ARM. If you do, please remove the temp from the
lithium instruction.

http://codereview.chromium.org/6368138/diff/1002/src/arm/lithium-codegen-arm....
src/arm/lithium-codegen-arm.cc:3803: Register temp2 =
ToRegister(instr->TempAt(1));
Could use scratch0().

http://codereview.chromium.org/6368138/diff/1002/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/6368138/diff/1002/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:2193: protected:
Blank line before protected?

http://codereview.chromium.org/6368138/diff/1002/src/ia32/lithium-codegen-ia3...
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/6368138/diff/1002/src/ia32/lithium-codegen-ia3...
src/ia32/lithium-codegen-ia32.cc:3582: Label true_label;
Make these NearLabel?

http://codereview.chromium.org/6368138/diff/1002/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6368138/diff/1002/src/runtime.cc#newcode6717
src/runtime.cc:6717: Handle<Object> result = Execution::New(
Move "Execution::New(" to the next line as well?

http://codereview.chromium.org/6368138/diff/1002/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6368138/diff/1002/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:2254: Label true_label;
NearLabel?

Expand Messages | Collapse Messages