Issue 6368129: Add build flag for iterative vm testing.

Created:
9 years, 10 months ago by sosa

Modified:
9 years, 10 months ago

Reviewers:
kmixter1, msb

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Add build flag for iterative vm testing. Change-Id: Ib8258b33f87aeadfbaee145bdf7ab460af66c39f BUG=N0ne TEST=Ran it with --build Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=519a656

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	bin/cros_run_vm_test	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mandeep Singh Baines

sosa@chromium.org (sosa@chromium.org) wrote: > Reviewers: kmixter1, > > Message: > Ran across this when adding ...

9 years, 10 months ago (2011-02-07 18:37:46 UTC) #2

sosa

I'm not sure anyone is using the b for board short option. Honestly I'm not ...

9 years, 10 months ago (2011-02-07 18:39:55 UTC) #3

I'm not sure anyone is using the b for board short option. Honestly
I'm not sure anyone is using this scripts besides me or the builders
(and they use the long option).

Was trying to decide would it be better to keep exactly the same as
run_remote_tests (which has b/build) or make some new short or no
short for cros_run_vm_test.

On Mon, Feb 7, 2011 at 10:37 AM, Mandeep Singh Baines <msb@chromium.org> wrote:
> sosa@chromium.org (sosa@chromium.org) wrote:
>> Reviewers: kmixter1,
>>
>> Message:
>> Ran across this when adding a test :)
>>
>> Description:
>> Add build flag for iterative vm testing.
>>
>> Change-Id: Ib8258b33f87aeadfbaee145bdf7ab460af66c39f
>>
>> BUG=N0ne
>> TEST=Ran it with --build
>>
>> Please review this at http://codereview.chromium.org/6368129/
>>
>> SVN Base: http://git.chromium.org/git/crosutils.git@master
>>
>> Affected files:
>>   M bin/cros_run_vm_test
>>
>>
>> Index: bin/cros_run_vm_test
>> diff --git a/bin/cros_run_vm_test b/bin/cros_run_vm_test
>> index
8c7f68f97323cb313ff7db290fa87f03f13a52b0..1b0e6d9be917739eaee5f5dd721b57b963557279
>> 100755
>> --- a/bin/cros_run_vm_test
>> +++ b/bin/cros_run_vm_test
>> @@ -36,7 +36,8 @@ MAX_RETRIES=3
>>  get_default_board
>>
>>  DEFINE_string board "$DEFAULT_BOARD" \
>> -    "The board for which you built autotest." b
>> +    "The board for which you built autotest."
>
> Hmm, not a good idea to change the meaning of a short opt.
>
>> +DEFINE_boolean build ${FLAGS_FALSE} "Build tets while running" b
>
> s/tets/test/
>
>>  DEFINE_string image_path "" "Full path of the VM image"
>>  DEFINE_string results_dir_root "" "alternate root results directory"
>>  DEFINE_string test_case "" "Name of the test case to run"
>> @@ -104,8 +105,13 @@ if [ -n "${FLAGS_verify_chrome_version}" ]; then
>>    fi
>>  fi
>>
>> +# Set the build flag for run_remote_tests.
>> +BUILD_FLAG=""
>> +[ ${FLAGS_build}-eq ${FLAGS_true} ] && BUILD_FLAG="--build"
>> +
>>  "${SCRIPTS_DIR}/run_remote_tests.sh" \
>>      --board=${FLAGS_board} \
>> +    ${BUILD_FLAG} \
>>      --ssh_port=${FLAGS_ssh_port} \
>>      --remote=127.0.0.1 \
>>      --results_dir_root="${FLAGS_results_dir_root}" \
>>
>>
>

msb

Chris Sosa (sosa@chromium.org) wrote: > I'm not sure anyone is using the b for board ...

9 years, 10 months ago (2011-02-07 18:59:56 UTC) #4

Chris Sosa (sosa@chromium.org) wrote:
> I'm not sure anyone is using the b for board short option. Honestly
> I'm not sure anyone is using this scripts besides me or the builders
> (and they use the long option).
> 

Ah. LGTM after fixing spelling.

> Was trying to decide would it be better to keep exactly the same as
> run_remote_tests (which has b/build) or make some new short or no
> short for cros_run_vm_test.
> 
> On Mon, Feb 7, 2011 at 10:37 AM, Mandeep Singh Baines <msb@chromium.org>
wrote:
> > sosa@chromium.org (sosa@chromium.org) wrote:
> >> Reviewers: kmixter1,
> >>
> >> Message:
> >> Ran across this when adding a test :)
> >>
> >> Description:
> >> Add build flag for iterative vm testing.
> >>
> >> Change-Id: Ib8258b33f87aeadfbaee145bdf7ab460af66c39f
> >>
> >> BUG=N0ne
> >> TEST=Ran it with --build
> >>
> >> Please review this at http://codereview.chromium.org/6368129/
> >>
> >> SVN Base: http://git.chromium.org/git/crosutils.git@master
> >>
> >> Affected files:
> >>   M bin/cros_run_vm_test
> >>
> >>
> >> Index: bin/cros_run_vm_test
> >> diff --git a/bin/cros_run_vm_test b/bin/cros_run_vm_test
> >> index
8c7f68f97323cb313ff7db290fa87f03f13a52b0..1b0e6d9be917739eaee5f5dd721b57b963557279
> >> 100755
> >> --- a/bin/cros_run_vm_test
> >> +++ b/bin/cros_run_vm_test
> >> @@ -36,7 +36,8 @@ MAX_RETRIES=3
> >>  get_default_board
> >>
> >>  DEFINE_string board "$DEFAULT_BOARD" \
> >> -    "The board for which you built autotest." b
> >> +    "The board for which you built autotest."
> >
> > Hmm, not a good idea to change the meaning of a short opt.
> >
> >> +DEFINE_boolean build ${FLAGS_FALSE} "Build tets while running" b
> >
> > s/tets/test/
> >
> >>  DEFINE_string image_path "" "Full path of the VM image"
> >>  DEFINE_string results_dir_root "" "alternate root results directory"
> >>  DEFINE_string test_case "" "Name of the test case to run"
> >> @@ -104,8 +105,13 @@ if [ -n "${FLAGS_verify_chrome_version}" ]; then
> >>    fi
> >>  fi
> >>
> >> +# Set the build flag for run_remote_tests.
> >> +BUILD_FLAG=""
> >> +[ ${FLAGS_build}-eq ${FLAGS_true} ] && BUILD_FLAG="--build"
> >> +
> >>  "${SCRIPTS_DIR}/run_remote_tests.sh" \
> >>      --board=${FLAGS_board} \
> >> +    ${BUILD_FLAG} \
> >>      --ssh_port=${FLAGS_ssh_port} \
> >>      --remote=127.0.0.1 \
> >>      --results_dir_root="${FLAGS_results_dir_root}" \
> >>
> >>
> >

kmixter1

9 years, 10 months ago (2011-02-07 19:07:03 UTC) #5

LGTM

On Mon, Feb 7, 2011 at 10:59 AM, Mandeep Singh Baines <msb@google.com>wrote:

> Chris Sosa (sosa@chromium.org) wrote:
> > I'm not sure anyone is using the b for board short option. Honestly
> > I'm not sure anyone is using this scripts besides me or the builders
> > (and they use the long option).
> >
>
> Ah. LGTM after fixing spelling.
>
> > Was trying to decide would it be better to keep exactly the same as
> > run_remote_tests (which has b/build) or make some new short or no
> > short for cros_run_vm_test.
> >
> > On Mon, Feb 7, 2011 at 10:37 AM, Mandeep Singh Baines <msb@chromium.org>
> wrote:
> > > sosa@chromium.org (sosa@chromium.org) wrote:
> > >> Reviewers: kmixter1,
> > >>
> > >> Message:
> > >> Ran across this when adding a test :)
> > >>
> > >> Description:
> > >> Add build flag for iterative vm testing.
> > >>
> > >> Change-Id: Ib8258b33f87aeadfbaee145bdf7ab460af66c39f
> > >>
> > >> BUG=N0ne
> > >> TEST=Ran it with --build
> > >>
> > >> Please review this at http://codereview.chromium.org/6368129/
> > >>
> > >> SVN Base: http://git.chromium.org/git/crosutils.git@master
> > >>
> > >> Affected files:
> > >>   M bin/cros_run_vm_test
> > >>
> > >>
> > >> Index: bin/cros_run_vm_test
> > >> diff --git a/bin/cros_run_vm_test b/bin/cros_run_vm_test
> > >> index
>
8c7f68f97323cb313ff7db290fa87f03f13a52b0..1b0e6d9be917739eaee5f5dd721b57b963557279
> > >> 100755
> > >> --- a/bin/cros_run_vm_test
> > >> +++ b/bin/cros_run_vm_test
> > >> @@ -36,7 +36,8 @@ MAX_RETRIES=3
> > >>  get_default_board
> > >>
> > >>  DEFINE_string board "$DEFAULT_BOARD" \
> > >> -    "The board for which you built autotest." b
> > >> +    "The board for which you built autotest."
> > >
> > > Hmm, not a good idea to change the meaning of a short opt.
> > >
> > >> +DEFINE_boolean build ${FLAGS_FALSE} "Build tets while running" b
> > >
> > > s/tets/test/
> > >
> > >>  DEFINE_string image_path "" "Full path of the VM image"
> > >>  DEFINE_string results_dir_root "" "alternate root results directory"
> > >>  DEFINE_string test_case "" "Name of the test case to run"
> > >> @@ -104,8 +105,13 @@ if [ -n "${FLAGS_verify_chrome_version}" ]; then
> > >>    fi
> > >>  fi
> > >>
> > >> +# Set the build flag for run_remote_tests.
> > >> +BUILD_FLAG=""
> > >> +[ ${FLAGS_build}-eq ${FLAGS_true} ] && BUILD_FLAG="--build"
> > >> +
> > >>  "${SCRIPTS_DIR}/run_remote_tests.sh" \
> > >>      --board=${FLAGS_board} \
> > >> +    ${BUILD_FLAG} \
> > >>      --ssh_port=${FLAGS_ssh_port} \
> > >>      --remote=127.0.0.1 \
> > >>      --results_dir_root="${FLAGS_results_dir_root}" \
> > >>
> > >>
> > >
>

Expand Messages | Collapse Messages