Issue 6368097: X64 Crankshaft: Port TaggedToI to X64.

Issue 6368097: X64 Crankshaft: Port TaggedToI to X64. (Closed)

Created:
9 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Crankshaft: Port TaggedToI to X64. Committed: http://code.google.com/p/v8/source/detail?r=6637

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -3 lines)			Patch
M	src/x64/assembler-x64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/x64/disasm-x64.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	2 chunks	+62 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/6368097/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6368097/diff/1/src/x64/lithium-codegen-x64.cc#newcode1973 src/x64/lithium-codegen-x64.cc:1973: Heap::kHeapNumberMapRootIndex); indentation. http://codereview.chromium.org/6368097/diff/1/src/x64/lithium-codegen-x64.cc#newcode1986 src/x64/lithium-codegen-x64.cc:1986: CpuFeatures::Scope scope(SSE3); Fisttp isn't ...

9 years, 10 months ago (2011-02-04 12:57:55 UTC) #2

William Hesse

9 years, 10 months ago (2011-02-04 13:16:39 UTC) #3

http://codereview.chromium.org/6368097/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6368097/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:1973: Heap::kHeapNumberMapRootIndex);
On 2011/02/04 12:57:55, Lasse Reichstein wrote:
> indentation.

Done.

http://codereview.chromium.org/6368097/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:1986: CpuFeatures::Scope scope(SSE3);
On 2011/02/04 12:57:55, Lasse Reichstein wrote:
> Fisttp isn't any "more powerful" than cvttsd2si in X64 mode, since we have a
> 64-bit version of that too. I.e., the valid ranges are the same. Use the
64-bit
> cvttsd2si in all cases, and avoid the FPU stack.

Done.

http://codereview.chromium.org/6368097/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2000: __ fincstp();
Entire block of code deleted.
On 2011/02/04 12:57:55, Lasse Reichstein wrote:
> Use
>   __ fstp(0);
> to drop the top of the FPU stack.

http://codereview.chromium.org/6368097/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2014: __ cvttsd2si(input_reg, xmm0);
On 2011/02/04 12:57:55, Lasse Reichstein wrote:
> Use the 64-bit version and compare to 0x8000000000000000 instead.

Done.

Expand Messages | Collapse Messages