Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3862)

Unified Diff: chrome/browser/dom_ui/options/browser_options_handler.cc

Issue 6368094: -Wuninitialized fixes Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/extensions/extension_browsertests_misc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/options/browser_options_handler.cc
diff --git a/chrome/browser/dom_ui/options/browser_options_handler.cc b/chrome/browser/dom_ui/options/browser_options_handler.cc
index 83d52234b94066da978225580cb267c540d027f1..95c5452e160148079cc364b08bb74485060c5931 100644
--- a/chrome/browser/dom_ui/options/browser_options_handler.cc
+++ b/chrome/browser/dom_ui/options/browser_options_handler.cc
@@ -155,6 +155,7 @@ void BrowserOptionsHandler::SetHomePage(const ListValue* args) {
!args->GetString(1, &do_fixup_string) ||
!base::StringToInt(do_fixup_string, &do_fixup)) {
CHECK(false);
+ return; // needs analysis why this is needed
};
if (do_fixup) {
@@ -383,6 +384,7 @@ void BrowserOptionsHandler::AddStartupPage(const ListValue* args) {
!args->GetString(1, &index_string) ||
!base::StringToInt(index_string, &index)) {
CHECK(false);
+ return; // needs analysis why this is needed
};
if (index == -1)
@@ -405,6 +407,7 @@ void BrowserOptionsHandler::EditStartupPage(const ListValue* args) {
!base::StringToInt(index_string, &index) ||
!args->GetString(1, &url_string)) {
CHECK(false);
+ return; // needs analysis why this is needed
};
if (index < 0 || index > startup_custom_pages_table_model_->RowCount()) {
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/extensions/extension_browsertests_misc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698